Use Geolocation API to center map by current location on load in certain cases #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #192
This is
Unfortunately, it appears that checking if a user has already given location permissions is only possible through an async promise. Therefore, the options are either making the map load wait until we can pass in user's geo coords or recentering the map after the mapBox object has been created.
In my approach, I try to kick off the permissions query asap. Inside a
useEffect
hook, we recenter the map as soon as the permissions query promise resolves and there is amap
object in state. This is not guaranteed to run beforemapboxMap
kicks off itsload
event.Assumptions:
Manually Tested: